testing: Add a system-provided postgres for testing #8323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202506-system-postgres
branch
4 times, most recently
from
c1fbeef to
4841a58
Compare
Postgres can be slow to spin up and down clusters for each test. This patch allows us to just test against an externally managed postgres instance. This is particularly interesting in CI, where we can run a postgres service in a separate container. The provider still uses nonce-based multitenancy. It tries to clean up, but it can fail if a test gets interrupted or teardown fails.
cdecker
force-pushed
the
202506-system-postgres
branch
from
0de761a to
59d8e65
Compare
|
I am having a bit of trouble with the separate postgres service running out of disk space. I am trying a couple of things, but maybe this will be kept as a sped up developer option, rather than running it in CI. |
Running against a `system-postgres` can cause the disk to fill up. Cleaning up some more space hopefully makes them work again. Technically the postgres DBs are deleted after the test, however that may be delayed, and many nodes in parallel will cause the disk to fill up.
cdecker
force-pushed
the
202506-system-postgres
branch
from
59d8e65 to
f825602
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres can be slow to spin up and down clusters for each test. This
patch allows us to just test against an externally managed postgres
instance. This is particularly interesting in CI, where we can run a
postgres service in a separate container.
The provider still uses nonce-based multitenancy. It tries to clean
up, but it can fail if a test gets interrupted or teardown fails.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
Changelog-None