Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add orientation info #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mukhtarfauzi
Copy link

why there is no orientation info in these packages?

@FilledStacks
Copy link
Owner

I removed the orientation so replace it with the orientation builder to keep those responsibilities separate. I wanted to make use of the already existing orientation widget to provide that functionality.

There was also a bug with the orientation from the media query where it would sometimes report the old orientation.

@basnetjiten
Copy link

basnetjiten commented Feb 27, 2022

OrientationBuilder does not builds upon orientation change in Ipad simulator. Is the issue with media query still remains?

ScreenTypeLayout(
  breakpoints:
      const ScreenBreakpoints(desktop: 900, tablet: 650, watch: 250),
  mobile: OrientationLayoutBuilder(

      portrait: (context) => const ProgramPortraitView(),
      landscape: (context) => const ProgramLandscapeView()),
  desktop
    : OrientationLayoutBuilder(
      portrait: (context) => const ProgramPortraitView(),
      landscape: (context) => const ProgramLandscapeView()),
)

@FilledStacks
Copy link
Owner

@basnetjiten I think so. I can't be certain. This works for us.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants