Edge browser support #1011
Edge browser support #1011
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1088,6 +1088,10 @@ private BrowserMatcher getBrowserAllowList(ReadableArray androidAllowCustomBrows | |||
| browserMatchers.add(VersionedBrowserMatcher.SAMSUNG_CUSTOM_TAB); | |||
| break; | |||
| } | |||
| case "edge": { | |||
| browserMatchers.add(VersionedBrowserMatcher.EDGE_CUSTOM_TAB); | |||
There was a problem hiding this comment.
When I run npx react-native run-android I get the following:
error: cannot find symbol browserMatchers.add(VersionedBrowserMatcher.EDGE_CUSTOM_TAB);As per these docs
However, when I comment this out, and set my default browser to Edge in the Android Emulator, the Example app does successfully open the links in Edge.
| @@ -714,6 +714,10 @@ - (NSString*)getErrorCode: (NSError*) error defaultCode: (NSString *) defaultCod | |||
| @"firefox": | |||
| ^{ | |||
| return [OIDExternalUserAgentIOSCustomBrowser CustomBrowserFirefox]; | |||
| }, | |||
| @"edge": | |||
There was a problem hiding this comment.
I get the following error when running npx react-native run-ios or when I try to build directly within Xcode: No known class method for selector 'CustomBrowserEdge'
Same here, I was able to confirm that I can open the URLs within the buttons in the Example app in Edge for iOS, but only after commenting this out.
Fixes #...
Description
Edge Browser Support