removal of unused function in AuthorizeController #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the controller is public, it should rather be deprecated first. |
GuilhemN
approved these changes
Feb 15, 2018
Controller/AuthorizeController.php
Outdated
| */ | ||
| protected function getRedirectionUrl(UserInterface $user) | ||
| { | ||
| @trigger_error('deprecated', E_USER_DEPRECATED); |
There was a problem hiding this comment.
@trigger_error(sprintf('%s() is deprecated since version 1.6 and will be removed in 2.0', __METHOD__))
Controller/AuthorizeController.php
Outdated
| @@ -242,9 +242,13 @@ protected function processSuccess(UserInterface $user, AuthorizeFormHandler $for | |||
| * @param UserInterface $user | |||
| * | |||
| * @return string | |||
| * | |||
| * @deprecated since 1.5.2, to be removed in 2.0 | |||
added 2 commits
February 17, 2018 00:20
…ndle into unused-code # Conflicts: # Controller/AuthorizeController.php
GuilhemN
reviewed
Feb 18, 2018
Controller/AuthorizeController.php
Outdated
| */ | ||
| protected function getRedirectionUrl(UserInterface $user) | ||
| { | ||
| @trigger_error(sprintf('%s() is deprecated since version 1.6 and will be removed in 2.0', __METHOD__)); | ||
|
|
There was a problem hiding this comment.
Please remove spaces, it makes the tests fail
GuilhemN
approved these changes
Feb 18, 2018
|
It should target 1.6, no? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.