Accept PHP 8.1's new $_FILES['full_path'] member #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gileri
force-pushed
the
php81-fullpath
branch
from
ef3f44d to
b15044c
Compare
gileri
force-pushed
the
php81-fullpath
branch
from
b15044c to
24a23ee
Compare
Tybaze
suggested changes
Jun 21, 2022
|
@Tybaze nice catch. Did you see it from the test suite? I wonder if it is covered. |
|
@alquerci , No, just reviewing the PR, got a doubt, make a custom test on an 7.4 env and trigger the error. We should create a specific "adaptive" test for 8.1+ and before, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 introduced a new member to the $_FILES superglobal.
This PR allows to accept both array members.