Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DoctrinePlugin] fix Swift_DoctrineSpool::queueMessage argument compatibility error #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

connorhu
Copy link
Collaborator

phpstan reported error

@connorhu connorhu requested review from thePanz and thirsch March 21, 2024 07:02
@connorhu connorhu force-pushed the fix/method-argument-compatibility-Swift_Mime_SimpleMessage branch from fcbd021 to b94107a Compare March 21, 2024 07:04
@connorhu
Copy link
Collaborator Author

connorhu commented Mar 21, 2024

Not so nice the green status with a php error. :(
Our testing system is not good enough yet.

@connorhu connorhu force-pushed the fix/method-argument-compatibility-Swift_Mime_SimpleMessage branch from b94107a to 5374bba Compare March 21, 2024 08:35
@thePanz
Copy link
Member

thePanz commented Mar 21, 2024

IIRC this depends on the version of SwiftMailer installed, or I am wrong?

@thirsch @mentalstring @alquerci I remember you worked on this topic before

@connorhu
Copy link
Collaborator Author

IIRC this depends on the version of SwiftMailer installed, or I am wrong?

If this is true, we are not compatible with the latest version.

@alquerci
Copy link
Contributor

alquerci commented Mar 21, 2024

@thirsch
Copy link
Collaborator

thirsch commented Mar 24, 2024

IIRC this depends on the version of SwiftMailer installed, or I am wrong?

If this is true, we are not compatible with the latest version.

Unfortunately, that's true. But changing it with this pr would break support for 5.x - Either we do drop 5.x or we should use a patch like the one from @alquerci. Another approach can be found in #279.

@connorhu
Copy link
Collaborator Author

connorhu commented Mar 25, 2024

To summarize: we support two versions of a library at the same time that is no longer being developed, another one should be used, but the right direction would be to make the framework not require any mail-related library. Nice.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants