Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update file ScreenCapturerAndroid.java from official commit https://w… #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gongluck
Copy link

@gongluck gongluck commented Nov 7, 2024

update file ScreenCapturerAndroid.java from official commit

this can slove #82

@gongluck gongluck requested a review from skydoves as a code owner November 7, 2024 09:34
@skydoves skydoves requested a review from kanat November 20, 2024 05:16
@skydoves
Copy link
Contributor

Thanks @gongluck for contributing to this project! @kanat will review this PR soon.

@gongluck
Copy link
Author

Thanks @gongluck for contributing to this project! @kanat will review this PR soon.

Thank you for the recognition. I'm eager to hear @kanat's thoughts on the changes.

@kanat
Copy link

kanat commented Nov 29, 2024

Hi @gongluck,

Thank you for the contribution ❤️

Would you mind moving this fix to our main WebRTC repo:

Cheers!

@gongluck
Copy link
Author

Hi @gongluck,

Thank you for the contribution ❤️

Would you mind moving this fix to our main WebRTC repo:

Cheers!

Oh, I didn't notice. GetStream's main webrtc repository has updated the ScreenCapturerAndroid source file, so it should be fine. But the current webrtc-android repository is not updated together?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants