Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[#44] Add API to disable tap-to-dismiss #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#44] Add API to disable tap-to-dismiss #53

wants to merge 1 commit into from

Conversation

marcuswu0814
Copy link
Contributor

@marcuswu0814 marcuswu0814 commented Nov 26, 2019 •
edited
Loading

Hi @rnystrom, this PR implement the #44.

  • Add a delegate method to check allow tap to dismiss. (If no delegate, default can be tap dismiss)
  • Add a delegate property for some use case, for example, when wrapped the delegate pattern to Delegate Proxy with RxSwift.

If there have any suggestions or concerns, please let me know. 😃 Thanks.

@marcuswu0814
Copy link
Contributor Author

Hi @BasThomas, could you help to review this PR and merge it? 🙏

@rizwankce
Copy link

LGTM :) @marcuswu0814 I don't have the write access to this repo though Im in the GItHawk org group

@BasThomas BasThomas removed their request for review March 3, 2023 15:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rizwankce rizwankce rizwankce approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcuswu0814 @rizwankce