refactor: Load connection info asynchronously. #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
force-pushed
the
gh-421-use-driver-hostname
branch
3 times, most recently
from
756561c to
fbb47da
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
from
f24d64b to
ef914ea
Compare
hessjcg
force-pushed
the
gh-421-use-driver-hostname
branch
2 times, most recently
from
bec7250 to
aef0672
Compare
hessjcg
force-pushed
the
gh-421-dns-config
branch
8 times, most recently
from
0fe1de1 to
8b53b78
Compare
hessjcg
force-pushed
the
gh-421-use-driver-hostname
branch
2 times, most recently
from
8796cc6 to
02a478d
Compare
hessjcg
force-pushed
the
gh-421-dns-changes
branch
from
8ac675a to
5865a71
Compare
hessjcg
force-pushed
the
gh-421-use-driver-hostname
branch
from
02a478d to
2441811
Compare
hessjcg
force-pushed
the
gh-421-dns-changes
branch
from
5865a71 to
f40ed77
Compare
hessjcg
force-pushed
the
gh-421-use-driver-hostname
branch
from
2441811 to
1d57555
Compare
…to old database. wip: periodic check for domain change wip: periodic checks wip: close sockets on instance closed
wip: make it work with mysql wip: connector test fixes.
hessjcg
force-pushed
the
gh-421-use-driver-hostname
branch
from
1d57555 to
2f65a7b
Compare
hessjcg
force-pushed
the
gh-421-dns-changes
branch
4 times, most recently
from
97b5fbc to
00b6cc7
Compare
hessjcg
force-pushed
the
gh-421-dns-changes
branch
2 times, most recently
from
22f259b to
4c9d1c4
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mysql and Postgres drivers require that their options.stream function immediately return a socket.
This refactors the connector so that it can return a SocketWrapper immediately, then delay the
connection of that socket until the asynchronous refresh operation finishes.
This will improve startup time for applications. This enable customers to use the standard host configuration
property instead of the Cloud SQL property "instance connection name". This will enable us to build lazy refresh
for the NodeJS connector.