Skip to content

Enable the SuiteSparse:GraphBLAS JIT #118

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Dec 17, 2023

This uses C config from sysconfig by default to try to make the JIT "just work" most of the time (as long as Python knows about a C compiler).

@michelp, I think you have explored using the JIT as much as anybody, so I would appreciate it if you took a careful look at this PR. Did I set everything correctly using sysconfig? I trust you more than myself for this ;)

Open questions:

  • Can we easily detect whether a C compiler exists (w/o shelling out); if so, should we disable if it doesn't?
  • What about OpenMP, which is very important for performance? Should we add or check for anything?
  • Does anybody want to add tests? :-P

@alugowski
Copy link
Collaborator

I think tests are a must. There appear to be quite a lot of settings to set with lots of opportunities for things to go wrong.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants