Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add hints in status bar when node_graph overlay is displayed #2415

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add hints in status bar when node_graph overlay is displayed #2415

wants to merge 4 commits into from

Conversation

Sidharth-Singh10
Copy link
Contributor

Closes #1820

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review March 9, 2025 23:30
@Keavon Keavon marked this pull request as draft March 13, 2025 00:59
@Keavon
Copy link
Member

Keavon commented Mar 13, 2025

Your approach only makes it show the hints momentarily, once, when the graph is opened. It needs to take control during that mode (and allow for supporting additional in-progress interactions).

@Sidharth-Singh10
Copy link
Contributor Author

Sidharth-Singh10 commented Mar 13, 2025 •
edited
Loading

@Keavon I moved update_node_graph_hints from DocumentMessageHandler to NodeGraphMessageHandler and implemented showing different hints based on current actions (dragging, wire connection, node selection)

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review March 13, 2025 17:59
@Keavon
Copy link
Member

Keavon commented Mar 17, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for a97e406
https://7ca4b2a1.graphite.pages.dev

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hints in the node graph
2 participants
@Sidharth-Singh10 @Keavon