Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes issues from code todo list #2473

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

4adex
Copy link
Contributor

@4adex 4adex commented Mar 19, 2025

https://discord.com/channels/731730685944922173/881073965047636018/1349537593276239892
Needed a new transaction to be started before extending a path.

https://discord.com/channels/731730685944922173/881073965047636018/1345511109452632127
Should check that if both handles length are 0. or f64::MAX then tool selected is one of path tool or pen tool, not the select tool.

https://discord.com/channels/731730685944922173/881073965047636018/1352035208232308828

@Keavon
Copy link
Member

Keavon commented Mar 20, 2025

#2439 completed the first part. Should your change be removed or does it help in some other way too, or do a better job?

@4adex
Copy link
Contributor Author

4adex commented Mar 20, 2025

Okay I wasn't aware of that, there was a confusion. There is already a start transaction before calling create_initial_point so things also work without the change I introduced.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants