Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix S3 file storage import #7318

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

nikitabelonogov
Copy link
Member

mirror for #6893

When using cloud storage, a task created from an imported image has a relative URL (e.g., `upload/1/d0672b53-ff-template.jpg`) that breaks when enabling cloud file storage.

The fix adds `CustomS3Boto3Storage::url` and utilizes it in the `FileUpload::read_task_from_uploaded_file` to make the app correctly display imported images.
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for label-studio-storybook failed. Why did it fail? →

Name Link
🔨 Latest commit 18aecfb
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-storybook/deploys/67ec2cf4d139bf00083a289c

Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 18aecfb
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67ec2cf47698c30008864b46
😎 Deploy Preview https://deploy-preview-7318--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nikitabelonogov nikitabelonogov mentioned this pull request Apr 1, 2025
16 tasks
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 18aecfb
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67ec2cf4d139bf00083a2898
😎 Deploy Preview https://deploy-preview-7318--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.81%. Comparing base (67eb5f6) to head (18aecfb).
Report is 402 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/core/storage.py 25.00% 3 Missing ⚠️
label_studio/data_import/models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7318   +/-   ##
========================================
  Coverage    76.81%   76.81%           
========================================
  Files          171      171           
  Lines        14032    14035    +3     
========================================
+ Hits         10778    10781    +3     
  Misses        3254     3254           
Flag Coverage Δ
pytests 76.81% <20.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants