-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: OPTIC-1938: Proxy for storages when presigned urls are off #7354
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
/fm sync |
/fm sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The one thing I think that remains is how we align the browsers ability to cache the requests. One part of this whole solution was a special ServiceWorker that caches the resolution of the URI's so that the browser can effectively cache the requests when able, like with images for example. This saves on bandwidth significantly in presigned url use cases with normal usage within DataManager -> QuickView. The ServiceWorker only acted on url's that had the word presign
in it, but now I see the endpoint is resolve
instead. This will mean that the previous behaviour will not work completely, so we will have to update the ServiceWorker accordingly as well. I can make that change on this PR.
…e handled the same way as before
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7354 +/- ##
===========================================
+ Coverage 77.26% 77.74% +0.47%
===========================================
Files 190 193 +3
Lines 14682 15082 +400
===========================================
+ Hits 11344 11725 +381
- Misses 3338 3357 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@bmartel great point! Thank you for the fix! |
Storage proxy added
Our current implementation with presigned urls:
This PR adds proxying from storages instead of redirecting to presigned urls:
Minor fixes
Fixed race condition on Project => Settings => Cloud Storages page when project=undefined on the first page loading.