-
Notifications
You must be signed in to change notification settings - Fork 548
WIP Use score in tree hyperparameter notebook #503
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started to review this PR but I noticed that it requires blackification first.
accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | ||
|
||
_ = plt.title( | ||
f"Shallow regression tree with max-depth of {max_depth}" | ||
f"\n R$^2$ of the fit: {accuracy:.2f}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
_ = plt.title( | |
f"Shallow regression tree with max-depth of {max_depth}" | |
f"\n R$^2$ of the fit: {accuracy:.2f}" | |
) | |
r2 = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
_ = plt.title( | |
f"Shallow regression tree with max-depth of {max_depth}" | |
f"\n R$^2$ of the fit: {r2:.2f}" | |
) |
accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | ||
|
||
_ = plt.title( | ||
f"Shallow regression tree with max-depth of {max_depth}" | ||
f"\n R$^2$ of the fit: {accuracy:.2f}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accuracy = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
_ = plt.title( | |
f"Shallow regression tree with max-depth of {max_depth}" | |
f"\n R$^2$ of the fit: {accuracy:.2f}" | |
) | |
r2 = tree_reg.score(data_reg[data_reg_columns], data_reg[target_reg_column]) | |
_ = plt.title( | |
f"Shallow regression tree with max-depth of {max_depth}" | |
f"\n R$^2$ of the fit: {r2:.2f}" | |
) |
This PR isolate the call to score in the hyperparameter notebook.
It is linked to the comment: #464 (comment)
In this PR, we should therefore address the concern of @ogrisel: