refactor: Keyboard focus ring controller #1684
Conversation
… into rkaraivanov/focus-ring-refactor
| 'keyup', | ||
| 'focusout', | ||
| 'pointerdown', |
There was a problem hiding this comment.
Was going to note that pointerdown is not exactly the same as click in terms of user interaction, though that behavior is entirely defined by us (browser's native focus-visible seems to clear on blur only), so it's prob fine.
Speaking of blur, that's also not quite the same since focusout bubbles, right? How safe is that change - I saw the carousel addition to prevent it, but could some internal content (user content/tempaltes) mess with the handler?
There was a problem hiding this comment.
Seems like the only possible issue is with carousel that already used focusout instead of blur like the buttons for example, so it might be a non-issue. Still, only trying to figure out if that can creep on us in the future
No description provided.