Skip to content

Technical debt changes in indexing functions #2012

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Feb 21, 2025

This PR cleans up indexing functions

  • Renames Python bindings from usm_ndarray_take and usm_ndarray_put to py_take and py_put to improve consistency with the rest of dpctl
  • Removes indexing mode macros, opting for a ternary check instead
  • Refactors to break up _populate_kernel_params internal function to improve code readability [WIP]
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the technical-debt-indexing-fns branch 3 times, most recently from 4802fbd to 7dfd4b9 Compare February 21, 2025 22:02
Copy link

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_537 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@ndgrigorian ndgrigorian force-pushed the technical-debt-indexing-fns branch from 7dfd4b9 to 0d7baf0 Compare February 22, 2025 01:22
Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_537 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Feb 22, 2025

Coverage Status

coverage: 86.381%. remained the same
when pulling d409117 on technical-debt-indexing-fns
into bc7a739 on master.

@ndgrigorian ndgrigorian force-pushed the technical-debt-indexing-fns branch from 0d7baf0 to d409117 Compare April 9, 2025 03:50
Copy link

github-actions bot commented Apr 9, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_115 ran successfully.
Passed: 913
Failed: 1
Skipped: 154

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants