Skip to content

Extend build_locally.py with --target-cuda and --target-hip arguments #2109

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests extending build_locally.py script by adding --target-cuda and --target-hip arguments
to simplify configuration of CUDA and AMD targets without manually passing CMake options.

python scripts/build_locally.py --target-cuda --target-hip=gfx1030

Also updates the documentation to reflect the new changes

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_46 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

Base automatically changed from update_amd_build to master June 23, 2025 21:33
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.903% (+0.9%) from 84.989%
when pulling 4e250d6 on add_targets_args
into 716d3ff on master.

Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_51 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants