Skip to content

Adjust Windows-only logic in __init__.py #2553

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 6, 2025

This PR suggests small changes to Windows-specific logic in __init__.py

hasattr(os, "add_dll_directory") is unnecessary after platform check and is removed, and sys.platform == "win32" is used which is more commonly seen in the ecosystem and avoids importing platform module

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Copy link
Contributor

github-actions bot commented Aug 6, 2025

View rendered docs @ https://intelpython.github.io/dpnp/pull/2553/index.html

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_15 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Aug 6, 2025

Coverage Status

coverage: 72.125% (-0.001%) from 72.126%
when pulling bbe5985 on adjust-windows-platform-check
into ac795ab on master.

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Aug 6, 2025
@antonwolfy
Copy link
Contributor

Could you please add the PR to the changelog also?

@ndgrigorian
Copy link
Collaborator Author

Could you please add the PR to the changelog also?

done, it's been added

@ndgrigorian ndgrigorian requested a review from antonwolfy August 22, 2025 18:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants