Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added: new configcpi.py #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

paulwratt
Copy link
Contributor

just the new file, because of the way the current updater checks. also contains a proper debug_level output handler, although the function needs to be embedded in each page to make it clean (easily usable). also all global config values are already converted

@paulwratt
Copy link
Contributor Author

There is an alternate way of doing this, and that is for me to roll my own CommanderPi2 which has all the changes, fixes, updates and different model & OS checks and values, and then for you to pull that back into your repo as a branch. That way you can cherry pick what you want, and adapt/learn the code as you go.

eg 1) I already havew a version of the update.py that only has one filename list/array, with the version check file at (1st) position in Files[0] (which is built from Names[]). I also changed the git url builder to make it easy for developers to test different versions (helped by removing all $HOME and .../CommanderPi/... references - replaced with cpi.path)

eg 2) I replaced all read/write/append code with functions in resources.py, so it s now only 8.3Kb, but I am going to add a bunch of arrays (or lists) to allow for (sane) defaults (and overclocks) for ALL RPi versions (not just RPi 4). Technically it should be fine to add the NanoPi series as well (because they boot the same as RPi - ie without UEFI), but I dont have one to test with atm.

eg 3) I intend to allow to work with PC Raspbian (RaspberryPiOS for PC) at least, which should make it work with almost any Debian based OS

with all those changes, that version of CommanderPi should be ready for repo inclusion. Especially for someone running RaspberryPiOS on an x86 Mac :)

@Jack477
Copy link
Owner

Jack477 commented Nov 13, 2020

Sure, I'm open for Your suggestions and glad that you wanna help to improve CommanderPi :)
I will open beta branch from master, you can merge all stuff there. When 1.0 release will arrive we can connect the best thing from master and beta branch together. You can contact with me by PiLabs Discord https://discord.gg/rq5FVgC7 . There is a channel CommanderPi-support

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants