feat: add an option to translate JS_IR with DCE. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpachoo
reviewed
Jul 11, 2022
| @@ -51,8 +51,10 @@ class KotlinProjectExecutor( | |||
| return convertJsWithConverter(project, kotlinToJSTranslator::doTranslate) | |||
| } | |||
|
|
|||
| fun convertToJsIr(project: Project): TranslationJSResult { | |||
| return convertJsWithConverter(project, kotlinToJSTranslator::doTranslateWithIr) | |||
| fun convertToJsIr(project: Project, shouldEliminateDeadCode: Boolean): TranslationJSResult { | |||
There was a problem hiding this comment.
Please, fix the usages of the method or set a default value for "shouldEliminateDeadCode".
BaseExecutorTest will not pass due to the method's signature mismatch.
There was a problem hiding this comment.
also it;s good to have additional test for that feature
AlexanderPrendota
requested changes
Jul 29, 2022
| fun runJsIrWithDce( | ||
| code: String, | ||
| contains: String = "", | ||
| notContain: String = "", |
There was a problem hiding this comment.
notContains mb?
|
@JSMonk do u need it? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an query argument for adding dead code elimination step before IR to JS translating