Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix case where var_pooled contains zeros #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tom-osika
Copy link

Hi @Jfortin1

Thanks for providing this python package, this has been incredibly useful for some research I'm doing currently.

When adjusting the values of the var_pooled array that are zero, I think it was meant to take the median of the nonzero values of the array, not the median of the intermediate binary array (which would either be 0 or 1).

Let me know if this change is correct, I haven't studied the code extremely in-depth.

Thanks again,
Tom

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant