Fix to Mailchimp failing to respond to Expect: 100-Continue headers #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Php Curl automatically adds this header, which causes Mailchimp to reject the api call.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change:
We discovered in the past week that Mailchimp does not respond to large patch payloads.
Further digging discovered that php curl is automatically adding the Expect: 100-continue header to the request which was causing the majority of our Patch requests to fail.
Description of implementation:
To fix this we have set an empty Expect: in the get headers function.
Risks & Mitigation:
Unit test written..