Skip to content

use oneunit, not one, to preserve type in single_seed #665

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevengj
Copy link
Contributor

@stevengj stevengj commented Sep 18, 2023

Fixes #651

This change is also required by #664, so if that PR is accepted then it supersedes this PR.

@stevengj stevengj changed the title use oneunit, not one, to preserve type use oneunit, not one, to preserve type in single_seed Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.07% ⚠️

Comparison is base (d300209) 89.65% compared to head (1db2302) 86.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   89.65%   86.59%   -3.07%     
==========================================
  Files          11       10       -1     
  Lines         967      895      -72     
==========================================
- Hits          867      775      -92     
- Misses        100      120      +20     
Files Changed Coverage Δ
src/partials.jl 84.07% <100.00%> (-0.14%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

construct_seeds for types where typeof(one(T)) !=T is broken
1 participant