Add generic interface to change codegen params #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbaraldi
force-pushed
the
gb/codegen_params
branch
4 times, most recently
from
16fd0e4 to
1a5981d
Compare
maleadt
force-pushed
the
gb/codegen_params
branch
from
1a5981d to
7411e9f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 84.55% 74.58% -9.97%
==========================================
Files 24 24
Lines 3309 3282 -27
==========================================
- Hits 2798 2448 -350
- Misses 511 834 +323 ☔ View full report in Codecov by Sentry. |
|
CI failures don't occur on master so are likely related? |
maleadt
force-pushed
the
master
branch
5 times, most recently
from
1d233d7 to
e18b7c2
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new things every time a codegen_param gets added is problably getting old quite quickly, so add a generic interface for it.