-
Notifications
You must be signed in to change notification settings - Fork 4
Address some transform-related naming inconsistencies #63
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 47.55% 47.55%
=======================================
Files 37 37
Lines 942 942
=======================================
Hits 448 448
Misses 494 494
Continue to review full report at Codecov.
|
Most names changes are straightforward, I think. I'm not sure about |
If it's not very user facing, how about |
I am happy with |
It doesn't just check the type, it can also check the size of arrays, etc. |
Are you happy with the state of this @cscherrer ? |
@oschulz is this a minor or patch release? |
It'll have to be v0.12, some of these things have docstrings. So probably best to fix these naming inconsistencies now, I'd say. |
Ok, if I go ahead and tag this v0.12 and release it? |
We forgot a few additional types and functions when we renamed
vartransform
totransport_to
during the course of #62. This renames them to make things more consistent: