Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for AWS datasets #6

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Support for AWS datasets #6

merged 8 commits into from
Mar 8, 2024

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 7, 2023

CC @kdw503.

@kdw503 kdw503 force-pushed the teh/aws branch 2 times, most recently from b112c34 to fa980db Compare March 7, 2024 21:21
timholy
timholy commented Mar 8, 2024
View reviewed changes
Copy link
Member Author

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this working! Looks great, only minor tweaks mostly to the docstrings.

kdw503 and others added 6 commits March 8, 2024 11:09
@kdw503 @timholy
Update src/awsdata.jl
5b4d3cb 
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@kdw503 @timholy
Update src/awsdata.jl
9022d06 
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@kdw503 @timholy
Update src/awsdata.jl
7b2f7fe 
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@kdw503 @timholy
Update src/awsdata.jl
6386d42 
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@kdw503 @timholy
Update src/awsdata.jl
c907689 
Co-authored-by: Tim Holy <tim.holy@gmail.com>
@kdw503
add docstring for awsmanifest
b253390
@timholy timholy changed the title WIP: support for AWS datasets Support for AWS datasets Mar 8, 2024
@timholy timholy merged commit 65e6ab7 into master Mar 8, 2024
4 checks passed
@timholy timholy deleted the teh/aws branch March 8, 2024 19:46
@timholy
Copy link
Member Author

timholy commented Mar 8, 2024

Thanks for finishing this!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@kdw503 kdw503

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timholy @kdw503