Fix binary files being truncated when cached #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the cached Guzzle response is unserialized, the request/response stream is passed through PumpStream. The problem is that PumpStream uses plain `strlen()` to measure data "pumped" into the buffer (which is logically correct IMHO), whereas BodyStore and CacheEntry use `mb_` functions. This works just fine for "normal" (non-multibyte) text streams but breaks horribly in case of binart data (images etc.). The `mb_strlen()` counts some bytes as multibyte characters, returning smaller size, effectively causing the file being truncated when it's cached... Fixes Kevinrob#196
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cached Guzzle response is unserialized, the request/response stream is passed through PumpStream. The problem is that PumpStream uses plain
strlen()to measure data "pumped" into the buffer (which is logically correct IMHO), whereas BodyStore and CacheEntry usemb_functions.This works just fine for "normal" (non-multibyte) text streams but breaks horribly in case of binary data (images etc.). The
mb_strlen()counts some bytes as multibyte characters, returning smaller size, effectively causing the file being truncated when it's cached...Fixes #196