-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(DataSource): simplified data structure #635
feat(DataSource): simplified data structure #635
Conversation
382c45e
to
f59f77d
Compare
e69b644
to
af41f54
Compare
Little bug I'm having trouble fixing:
As |
Yeah, that's something we should guard against. I suspect the PET image has slices that are completely empty, so they are initializing the range to [0, 0]. We can defer colormap application, or we can guess a "reasonable" initial data range if that's even acceptable. |
FYI I do something similar in VolumeRendering, where the opacity function editor is delayed until the entire dataset is available (because it needs to compute a histogram). |
DataSource objects now represent a single type, rather than the bag-of-types done originally.
f59f77d
to
ef98d95
Compare
ff8d9d6
to
35628c1
Compare
DataSource objects now represent a single type, rather than the bag-of-types done originally.
@PaulHax this is the PR to test (stacked on
simplified-state-load-restore
andstreaming-base
).