fix(wheneverImageLoaded): run callback when switching images #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
The bug is that the current implementation of wheneverImageLoaded only watches a derived boolean (hasImageData) that only toggles when the image goes from not-loaded to loaded. If the imageId changes from one valid ID to another (with both returning true), the callback never fires.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #721 (hopefully)
The CT-Neck to Prostate switching worked OK for me. Switching between Prostate and Fetus had cropping issues for me. This PR fixes Prostate/Fetus case and hoefully gets the CT-Neck/Prostate in the issue.
The bug is that the current implementation of wheneverImageLoaded only watches a derived boolean (hasImageData) that only toggles when the image goes from not-loaded to loaded. If the imageId changes from one valid ID to another (with both returning true), the callback never fires.