-
Notifications
You must be signed in to change notification settings - Fork 67
Avoid using project.name for ignored projects check #262
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
2 tests failed, seems they are related to #261. kotlinx.validation.test.MultiPlatformSingleJvmTargetTest > testApiCheckFails FAILED
java.lang.AssertionError at MultiPlatformSingleJvmTargetTest.kt:84
* What went wrong:
Execution failed for task ':jvmApiCheck'.
> API check failed for project :.
--- /private/var/folders/_8/1blqtzds07g8p1zsy_t8_lsc0000gn/T/junit8648894727794548688/api/testproject.api
+++ /private/var/folders/_8/1blqtzds07g8p1zsy_t8_lsc0000gn/T/junit8648894727794548688/build/api/testproject.api
@@ -1,9 +1,9 @@
-public final class com/company/subsub2/Subsub2Class {
+public final class com/company/subsub1/Subsub1Class {
public fun <init> ()V
public final fun getProp ()I
}
-public final class com/company/subsub1/Subsub1Class {
+public final class com/company/subsub2/Subsub2Class {
public fun <init> ()V
public final fun getProp ()I
}
You can run :::apiDump task to overwrite API declarations kotlinx.validation.test.MultipleJvmTargetsTest > testApiCheckFails FAILED
java.lang.AssertionError at MultipleJvmTargetsTest.kt:99
* What went wrong:
Execution failed for task ':jvmApiCheck'.
> API check failed for project :.
--- /private/var/folders/_8/1blqtzds07g8p1zsy_t8_lsc0000gn/T/junit8084192555986675768/api/jvm/testproject.api
+++ /private/var/folders/_8/1blqtzds07g8p1zsy_t8_lsc0000gn/T/junit8084192555986675768/build/api/jvm/testproject.api
@@ -1,9 +1,9 @@
-public final class com/company/subsub2/Subsub2Class {
+public final class com/company/subsub1/Subsub1Class {
public fun <init> ()V
public final fun getProp ()I
}
-public final class com/company/subsub1/Subsub1Class {
+public final class com/company/subsub2/Subsub2Class {
public fun <init> ()V
public final fun getProp ()I
}
You can run :::apiDump task to overwrite API declarations |
f7a243a
to
33be62c
Compare
33be62c
to
3789ed7
Compare
3789ed7
to
4fe69a8
Compare
> The project's name is not necessarily unique within a project hierarchy. You should use the getPath() method for a unique identifier for the project. See https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#getName().
4fe69a8
to
b42f190
Compare
@Goooler thanks for taking care of the problem! While paths are better for identifying projects, there's already plethora of projects using BCV and relying on |
This might be a breaking change, but it would be worth breaking in the next release, users who want to update should update their Yeah, we can remove |
It's better to provide a smooth and graceful migration path when possible. Those who already use We just need to transform
into something like
And also update |
See https://docs.gradle.org/current/javadoc/org/gradle/api/Project.html#getName().