Add JsonObject field reading syntax sugar #3019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdvrieze
reviewed
Jun 10, 2025
| public fun JsonObject.getJsonArray(key: String): JsonArray? = this[key]?.jsonArray | ||
| public fun JsonObject.getJsonPrimitive(key: String): JsonPrimitive? = this[key]?.jsonPrimitive | ||
| public fun JsonObject.getJsonNull(key: String): JsonNull? = this[key]?.jsonNull | ||
| public fun JsonObject.getIntOrNull(key: String): Int? = this[key]?.jsonPrimitive?.intOrNull |
There was a problem hiding this comment.
This (and similar) functions should include a check that it is not a string isString should return false
There was a problem hiding this comment.
This (and similar) functions should include a check that it is not a string
isStringshould returnfalse
If I don't check isString , it seems to have no consequences, I guess it should be the converted type?
huicunjun
changed the title
|
@pdvrieze Can you review it |
|
@huicunjun It looks good to me (not an official maintainer so can't do anything beyond that) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Enhanced JsonObject deserialization and field reading syntax sugar