Skip to content

Add Death Message #1179

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 24 commits into from
May 16, 2025
Merged

Add Death Message #1179

merged 24 commits into from
May 16, 2025

Conversation

165135
Copy link
Contributor

@165135 165135 commented Jul 11, 2023

Send death message to a player after they die telling them who killed them and who assisted in the kill. Can be toggled on and off in the Inventory Settings tab.

@farooqkz
Copy link
Contributor

You are doing well young programmer ;)

@165135
Copy link
Contributor Author

165135 commented Jul 11, 2023

I did not know that #n puts the PR link and name... I know now XD

Copy link
Member

@LoneWolfHT LoneWolfHT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be made into a part of features.lua, as it's not a part of the kill list, and is basically just sending a chat message

@165135
Copy link
Contributor Author

165135 commented Jul 12, 2023

image
For some reason, its showing the setting multiple times

@165135
Copy link
Contributor Author

165135 commented Jul 12, 2023

Okay, I think the three time setting register is because functions.lua is somehow running 3 times, possibly, idk if this is me understanding something wrong or intentional
image

@165135
Copy link
Contributor Author

165135 commented Jul 12, 2023

Oh I'm silly its called from the three gamemode init.luas

@165135
Copy link
Contributor Author

165135 commented Jul 14, 2023

@farooqkz Did I miss something that needed to be changed?

@farooqkz
Copy link
Contributor

@farooqkz Did I miss something that needed to be changed?

Just tested. It's almost okay. There is a small typo which I'm gonna make suggestion for it. after you committed my suggestion, I will mark it as ready for review.

@farooqkz
Copy link
Contributor

@LoneWolfHT I haven't reviewed the code logic yet.

@farooqkz
Copy link
Contributor

@165135 I tested this a long time ago. Does it also say how much score your killer got?

165135 and others added 2 commits May 22, 2024 17:32
Co-authored-by: LoneWolfHT <lonewolf04361@gmail.com>
Co-authored-by: LoneWolfHT <lonewolf04361@gmail.com>
@165135
Copy link
Contributor Author

165135 commented May 23, 2024

I didn't even remember that this existed but ok

@LoneWolfHT
Copy link
Member

What do you think about also showing how many points were given for killing you? https://discord.com/channels/447819017391046687/1008040841102766153/1218686930833768612

Suggestion: On the death screen, show "<player_name> killed you for <points> points!"

@LoneWolfHT
Copy link
Member

Oh, I guess #1306 already does that

@LoneWolfHT LoneWolfHT merged commit d0ab30c into MT-CTF:master May 16, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants