-
Notifications
You must be signed in to change notification settings - Fork 93
Add Death Message #1179
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Death Message #1179
Conversation
You are doing well young programmer ;) |
I did not know that #n puts the PR link and name... I know now XD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be made into a part of features.lua, as it's not a part of the kill list, and is basically just sending a chat message
Oh I'm silly its called from the three gamemode init.luas |
@farooqkz Did I miss something that needed to be changed? |
Just tested. It's almost okay. There is a small typo which I'm gonna make suggestion for it. after you committed my suggestion, I will mark it as ready for review. |
@LoneWolfHT I haven't reviewed the code logic yet. |
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
Co-authored-by: Farooq Karimi Zadeh <fkz@riseup.net>
@165135 I tested this a long time ago. Does it also say how much score your killer got? |
Co-authored-by: LoneWolfHT <lonewolf04361@gmail.com>
Co-authored-by: LoneWolfHT <lonewolf04361@gmail.com>
I didn't even remember that this existed but ok |
What do you think about also showing how many points were given for killing you? https://discord.com/channels/447819017391046687/1008040841102766153/1218686930833768612
|
Oh, I guess #1306 already does that |
Send death message to a player after they die telling them who killed them and who assisted in the kill. Can be toggled on and off in the Inventory Settings tab.