fix(GoogleLogin): guarantee credential presence onSuccess #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a type assertion to the signature of
onSuccess
of theGoogleLogin
component to reflect that thecredentialResponse.credential
will always be present if the handler is called.The callback handler in the
GoogleLogin
component checks that thecredentialResponse.credential
is truthy, so it can't be the empty string when passed to onSuccess:Since the code guarantees this, the
onSuccess
handler shouldn't have to assert that the credential is present again. This PR adjusts the type of the parameter toonSuccess
so that thecredential
property is always truthy.