Skip to content

NOISSUE Detection of multiple custom theme folders #4076

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

phit
Copy link
Contributor

@phit phit commented Sep 6, 2021

No description provided.

@phit
Copy link
Contributor Author

phit commented Sep 6, 2021

do not merge yet, need to add fallback to a stock theme when the selected theme was deleted to
https://github.com/MultiMC/MultiMC5/blob/d644fb2094f623e45bff237ede7d432121f72072/launcher/MultiMC.cpp#L1145

also maybe fix the sorting of themes in the settings dropdown to be alphabetical by the display name of the theme

@ryleu
Copy link

ryleu commented Dec 25, 2021

You can make this a draft PR so that it doesn’t show as open.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants