Skip to content

Wcs handle errors #150

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Wcs handle errors #150

wants to merge 7 commits into from

Conversation

gbburkhardt
Copy link
Contributor

Description of the Change

  • bug fix: request to WCS is clipped to Sector size of data available on the server. Mapserver will return an error if the request is for a region outside of the extent of the layer.
  • bug fix: support case insensitive check for DTED extension; data sets exist in which the file extension is in caps.
  • add error handling for WCS operations
  • avoid memory/resource leaks

Why Should This Be In Core?

Bugs, of course, should be fixed. Memory/resource leaks are "bad". I added the error checks when I was debugging my setup of a WCS server for elevation data. They are likely to help others.

Benefits

more robust code

Potential Drawbacks

I was a bit concerned of the effect clipping the tile size to what's in the server would have on other code in the system. As far as I could tell, the ElevationModel correctly handles missing data, and if a request is made for data outside the clipped tile, the next ElevationModel in the list will be checked.

Applicable Issues

None that I know of...

@wcmatthysen wcmatthysen mentioned this pull request Apr 5, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant