Skip to content

Fix character reference parsing #569

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pharb
Copy link

@Pharb Pharb commented May 2, 2023

Ignore leading zeros and case-insensitive hexadecimal characters.

Purpose / Goal

Fixes: #568

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Note : Please ensure that you've read contribution guidelines before raising this PR. If your PR is in progress, please prepend [WIP] in PR title. Your PR will be reviewed when [WIP] will be removed from the PR title.

Bookmark this repository for further updates.

Benchmark

on master c7b3cea:

$ node benchmark/XmlParser.js
Running Suite: XML Parser benchmark
fxp v3 : 104492.65920369806 requests/second
fxp : 71740.31616855874 requests/second
fxp - preserve order : 79167.16811125632 requests/second
xmlbuilder2 : 30097.740319390698 requests/second
xml2js  : 19269.565779616878 requests/second

$ node benchmark/XmlBuilder.js
Running Suite: XML Builder benchmark
fxp : 115721.94119323186 requests/second
fxp - preserve order : 254535096.4923456 requests/second
xml2js  : 30245.690942021945 requests/second

on PR branch 7ffae07:

$  node benchmark/XmlParser.js
Running Suite: XML Parser benchmark
fxp v3 : 104906.50130850698 requests/second
fxp : 70241.16491572408 requests/second
fxp - preserve order : 77212.26547824622 requests/second
xmlbuilder2 : 30320.162156061833 requests/second
xml2js  : 19072.050992656794 requests/second

$ node benchmark/XmlBuilder.js
Running Suite: XML Builder benchmark
fxp : 114569.05961947251 requests/second
fxp - preserve order : 249648275.08603555 requests/second
xml2js  : 30008.326170982098 requests/second

Ignore leading zeros and case-insensitive hexadecimal characters.
Fixes: NaturalIntelligence#568
@amitguptagwl
Copy link
Member

Thanks for the PR. As there are some big changes in progress, I'll consider this PR after that or will pick them selectively.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some character reference formats not parsed correctly
2 participants