Fix #260 - tidy up GPU API #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feared as much, the C-string literal syntax is not supported by our Rust version. |
Requires Rust 1.77, I'll back out that change. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the types used in the GPU API. That lets us get rid of a lot of casts elsewhere (though a few new ones need to be inserted, and there will be a followup bug for this one, cleaning up types used in
psespecially). Some types were factored out into smalltypesmodule to create a shared bottom layer for all the subcommands.I also ran cargo fmt and cargo clippy to make sure things were as good as they could be, this meant inserting some clippy overrides here and there.
This should be squashed when landing, as there's some underlying noise in the history that's a result of my bungling my fork.