consolidated streams into 1 struct #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to update the blocks.rs and thermodynamics.rs modules before merging this branch |
…thermodynamics.rs
Iced gui into connector consolidation
…ms into a single struct
This trait will be implemented in each thermodynamic package (the thermodynamic packages will be structs). This will allow the user to switch between thermodynamic packages.
… package This will allow users to change thermodynamics package for blocks and streams
moved the IdealGasPackage struct into its own file and made it into a submodule of the thermodynamics module. In the future, as more packages are implemented, one simply needs to create another sub-module when implementing a new thermodynamics package
implemented function for entropy calculation for the ideal gas package. Need to look into how to incorporate the mass and mole fraction functions within the thermo packages and ensure that the thermopackage structs and the 'ThermoState' package are working together cohesively
…t matching the uml design
…rait Felt those functions were unncessary as the changes in volume and moles would be attributed to reactions. This would be something implmeneted within the block structs rather than the thermoState struct, which should mostly be about holding relevant thermodynamic equations.
… volume calculation under different EOS and based on vapor and liquid fractions
basically made it so that it will always return 1 for the vapor fraction function as one would only use the ideal gas package when working with only gaseous components and no liquid components.
need to figure out a way to calculate Cv for internal energy function
|
I haven't implemented all the test cases, but I thought it would be a good idea to push my current changes into the develop branch, as there have been a lot of changes that I have made. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated into one struct for streams.
Closes #20