Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Analytical Advection in jit #1612

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from
Draft

Conversation

erikvansebille
Copy link
Member

@erikvansebille erikvansebille commented Jul 26, 2024

This PR implements a C version of the AnalyticalAdvection kernel for use with JITParticles, and thereby implements #1617

  • make unit tests work
  • confirm AnalyticalAdvection also works on spherical grids
  • Support for models that don't have grid sizes provided (e.g. missing e1v, e2u etc for ORCA grids)
  • Implement B-grid support too
  • performance-test and validate AnalyticalAdvection in real-world scenarios
  • (potentially) make AnalyticalAdvection the default kernel in Parcels; or at least encourage its use in a new 'Choosing-Advection-Kernels-tutorial' (see also Add a tutorial to help users choose an appropriate advection kernel #1549)

@erikvansebille erikvansebille mentioned this pull request Jul 26, 2024
@erikvansebille erikvansebille self-assigned this Jul 26, 2024
@erikvansebille erikvansebille linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 26, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@michaeldenes
Copy link
Member

@erikvansebille is 47f50a0 the commit that will fix #1689 ?

@michaeldenes
Copy link
Member

@erikvansebille is 47f50a0 the commit that will fix #1689 ?

Looks like you already placed the fix in master! #1614

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

Implement AnalyticalAdvection Kernel in JIT
3 participants