Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement warnings in Parcels #1672

Merged
merged 17 commits into from
Sep 2, 2024

Typing

024aa35
Select commit
Loading
Failed to load commit list.
Merged

Implement warnings in Parcels #1672

Typing
024aa35
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2024 in 0s

81.10% (+0.07%) compared to 679d06d

View this Pull Request on Codecov

81.10% (+0.07%) compared to 679d06d

Details

Codecov Report

Attention: Patch coverage is 68.30357% with 71 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
parcels/kernel.py 43.33% 17 Missing ⚠️
parcels/field.py 63.63% 12 Missing ⚠️
parcels/fieldfilebuffer.py 38.88% 11 Missing ⚠️
parcels/grid.py 61.90% 8 Missing ⚠️
parcels/interaction/interactionkernel.py 38.46% 8 Missing ⚠️
parcels/particlefile.py 53.84% 6 Missing ⚠️
parcels/compilation/codegenerator.py 76.92% 3 Missing ⚠️
parcels/tools/warnings.py 76.92% 3 Missing ⚠️
parcels/particledata.py 50.00% 2 Missing ⚠️
parcels/particleset.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
+ Coverage   81.03%   81.10%   +0.07%     
==========================================
  Files          69       70       +1     
  Lines       13118    13197      +79     
  Branches      125      127       +2     
==========================================
+ Hits        10630    10704      +74     
- Misses       2451     2456       +5     
  Partials       37       37              
Files with missing lines Coverage Δ
parcels/fieldset.py 83.40% <100.00%> (+0.47%) ⬆️
parcels/tools/__init__.py 100.00% <100.00%> (ø)
parcels/tools/loggers.py 100.00% <100.00%> (+9.09%) ⬆️
tests/tools/test_converters.py 100.00% <ø> (ø)
tests/tools/test_warnings.py 100.00% <100.00%> (ø)
parcels/particleset.py 66.93% <80.00%> (+0.05%) ⬆️
parcels/particledata.py 70.91% <50.00%> (-0.14%) ⬇️
parcels/compilation/codegenerator.py 78.58% <76.92%> (-0.04%) ⬇️
parcels/tools/warnings.py 76.92% <76.92%> (ø)
parcels/particlefile.py 76.28% <53.84%> (-1.14%) ⬇️
... and 5 more

... and 1 file with indirect coverage changes