Skip to content

Adjust acl option yaml input syntax #112

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjbnz
Copy link
Contributor

@mjbnz mjbnz commented Jun 30, 2020

Having an acl entry requiring a single dictionary member called string seemed a little superfluous, so this patch adjusts the accepted syntax to include the following two examples, but also retain the string member format.

As an array of strings:

haproxy_frontend:
  - name: 'be-http'
    ....
    acl:
      - "is_foo hdr(host) -i foo.com"
      - "is_bar hdr(host) -i bar.com"

As a dictionary of named rules:

haproxy_backend:
  - name: 'be-http'
    ....
    acl:
      is_foo: "hdr(host) -i foo.com"
      is_bar: "hdr(host) -i bar.com"

Signed-off-by: Mike Beattie <mike@ethernal.org>
@mjbnz
Copy link
Contributor Author

mjbnz commented Aug 11, 2020

Hello, any chance that this PR might be accepted?

@tersmitten
Copy link
Member

This looks backwards compatible, am I correct?

@tersmitten
Copy link
Member

What's up with the | default(acl)?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants