Skip to content

[kotlin-spring] fix validation regression in kotlin-spring generator #21255

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

pstorch
Copy link
Contributor

@pstorch pstorch commented May 9, 2025

With introduction of the kotlin-misk generator in #20885, a regression #21238 was introduced in kotlin-spring generator.

This pull request reverts the changes in the kotlin-spring generator which were accidentally introduced by the above mentioned PR.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l

@wing328
Copy link
Member

wing328 commented May 11, 2025

@pstorch thanks for the PR

cc @andrewwilsonnew (the author of the kotlin misk server generator)

@wing328
Copy link
Member

wing328 commented May 11, 2025

@pstorch
Copy link
Contributor Author

pstorch commented May 11, 2025

@wing328: good idea. Tests added.

@andrewwilsonnew
Copy link
Contributor

andrewwilsonnew commented May 15, 2025

LGTM, nice! Apologies

@wing328 wing328 merged commit 5b885cd into OpenAPITools:master May 15, 2025
47 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants