Skip to content

fix(endpoints): enable select visibility when not stopped #1045

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(endpoints): enable select visibility when not stopped #1045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f9380f
Draft MR
zhendi Mar 31, 2025
31fd6b7
fix(endpoints): enable select visibility when not stopped
Mar 31, 2025
cc0e7d7
Merge branch 'csghub-main' into csghub__update-endpoints-settings
zhendi Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/endpoints/EndpointSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@
placeholder="Select"
size="large"
class="!w-[512px] sm:!w-full"
:disabled="!isStopped">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when removed, this means wether it is stopped or not, this field always be editable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, change visibility select will be always available

>
<el-option
v-for="item in visibilityOptions"
:key="item.value"
Expand Down