Fix thread syncronization problems #2204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a lot of possible memory overruns reported by helgrind coming from rbt_* operations without this flag.
We should not re-initialize thread_barrier, it is an UB.
This is implementation dependent, frown upon and triggering for sanitizers.
We should make sure that receiver gets something (error should do it), even if the worker thread suddenly terminates (e.g. thread_exit).
SEAP_cmd_exec function waiting branch was prone to spurious wakeups. Use pthread_cond_broadcast __SEAP_cmd_sync_handler to make sure all possible listeners are notified.
These log records were introduced in anticipation of the PCRE -> PCRE2 migration problems. We can get rid of them now.
evgenyz
changed the title
DO NOT MERGE
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain a set of commits with fixes to thread synchronization and memory handling.
See individual commits for details.