Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Into the unknown #14

Closed
wants to merge 8 commits into from
Closed

Into the unknown #14

wants to merge 8 commits into from

Conversation

doneill
Copy link
Collaborator

@doneill doneill commented Apr 19, 2024 •
edited
Loading

Summary

Preferable alternative to any, using the safer unknown

Fixes

Extension to eslint question in #13

Proposed changes

  • Replace all instances of any with unknown

Test

  • Confirm message references is not longer displaying
  • Run all the tests yarn test
  • Make sure all tests pass

@doneill doneill marked this pull request as draft April 19, 2024 23:12
@doneill
Copy link
Collaborator Author

doneill commented Apr 20, 2024

Closing, need to investigate better type usage

@doneill doneill closed this Apr 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@leo-ori leo-ori Awaiting requested review from leo-ori leo-ori is a code owner

@Alex79373 Alex79373 Awaiting requested review from Alex79373 Alex79373 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doneill