Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix duplicated required items #16

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix duplicated required items #16

merged 1 commit into from
May 7, 2024

Conversation

leo-ori
Copy link
Contributor

@leo-ori leo-ori commented May 4, 2024

Summary

Required duplicated items are invalid in JSON forms. This is validated to treat the error before reaching json forms component

Fixes

#15

Proposed changes

  • Check for duplicated items in schema.required array
  • Add a test case to validate it

Test

  • All test cases should pass by running yarn test

@leo-ori leo-ori requested review from doneill and Alex79373 as code owners May 4, 2024 01:24
@leo-ori leo-ori added the A - Task Engineering Task label May 4, 2024
doneill
doneill approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@doneill doneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work 👍

@doneill doneill added B - Ready To Merge PR is ready to be merged and removed A - Task Engineering Task labels May 6, 2024
@leo-ori leo-ori merged commit 084cf0f into develop May 7, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@doneill doneill doneill approved these changes

@Alex79373 Alex79373 Awaiting requested review from Alex79373 Alex79373 is a code owner

Assignees
No one assigned
Labels
B - Ready To Merge PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-ori @doneill