Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support date-time for fieldsets #8

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Support date-time for fieldsets #8

merged 2 commits into from
Apr 18, 2024

Conversation

leo-ori
Copy link
Contributor

@leo-ori leo-ori commented Apr 16, 2024 •
edited
Loading

Summary

Support date-time for fieldsets

Fixes

#7

Proposed changes

  • Support date-time format inside fieldsets in generateUISchema function
  • Add a test case for this date-time in fieldsets

Test

Run all the tests yarn test, make sure all tests pass

doneill
doneill reviewed Apr 16, 2024
View reviewed changes
doneill
doneill approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@doneill doneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work 👍

@doneill doneill added B - Ready To Merge PR is ready to be merged and removed B - Waiting for review labels Apr 18, 2024
@leo-ori leo-ori merged commit dca134f into develop Apr 18, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@doneill doneill doneill approved these changes

@Alex79373 Alex79373 Awaiting requested review from Alex79373 Alex79373 is a code owner

@hugohabel hugohabel Awaiting requested review from hugohabel

Assignees
No one assigned
Labels
B - Ready To Merge PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-ori @doneill