TemplateProcessor SetComplexBlock/Value and Sections #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHPOffice#2561. Allow the TemplateProcessor methods `setComplexBlock` and `setComplexValue` to work with Sections.
It currently makes only one substitution, with no way to determine if there are more. Add an additional optional parameter to allow multiple substitutions; default is false to match current implementation (so no break).
3 tasks
|
looks like it working with Section |
|
@vadykoo Thank you for confirming. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the TemplateProcessor methods
setComplexBlockandsetComplexValueto work with Sections.Fixes #2561
Checklist:
composer run-script check --timeout=0and no errors were reported