Skip to content

[BUGFIX] Ensure nested w:sdt -> w:sdtContent node parsing for Document #2599

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbuerk
Copy link
Contributor

@sbuerk sbuerk commented Apr 2, 2024

Nodes can be nested or directly provided for the document structure.
Until now, the sdt->sdtContent wrapping have not been respected.

This change moves the node parsing for a document to a dedicated
method and make it recursivly callable to unnest the wrapped node.

@coveralls
Copy link

coveralls commented Apr 2, 2024

Coverage Status

coverage: 97.136% (-0.08%) from 97.217%
when pulling bf40294 on sbuerk:stefan-3
into 8b891bb on PHPOffice:master.

@sbuerk sbuerk marked this pull request as draft April 2, 2024 13:05
@sbuerk sbuerk marked this pull request as ready for review April 2, 2024 13:14
Nodes can be nested or directly provided for the document structure.
Until now, the `sdt->sdtContent` wrapping have not been respected.

This change moves the node parsing for a document to a dedicated
method and make it recursivly callable to unnest the wrapped node.
@sbuerk sbuerk changed the title [BUGFIX] Ensure nested w:sdt -> w:sdtContent node paresing for Document [BUGFIX] Ensure nested w:sdt -> w:sdtContent node parsing for Document Apr 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants